Hello zyx, hello all, > On 05 April 2019 at 11:34 zyx <z...@gmx.us> wrote: > > > On Fri, 2019-04-05 at 10:30 +0200, Francesco Pretto wrote: > > Ok. Now there are no other outstanding patches from my side and > > yesterday I merged a pending change from Michal Sudolsky.
what about the post "[Podofo-users] [PATCH 3/5] PdfArray: Removed inheritance from std::vector" from 2019-01-14 23:08 +0100 and the following ones? You haven't retracted or already committed them? > > Hi, > aha, it seems the svn change notifications are not working again (on > the podofo-svn list). No big deal. > > I guess it would be good to reply to respective messages with pending > patches with a revision in which they've been merged into the sources, > thus there is some evidence that someone took care of it. As examples > (skipping those yours): > https://sourceforge.net/p/podofo/mailman/message/36484599/ I haven't tested that because I couldn't yet think of a document to test it with, I otherwise think it's fine (the library user can decide if it's sensible to use with some subset font AFAIK). It's not committed yet. > https://sourceforge.net/p/podofo/mailman/message/36532908/ I haven't tested that because I don't know the relevant standards, and I've had prioritized other things before asking about the ABI change that patch causes, no API change because the extra parameter to the constructor PdfSignatureField( PdfPage*, const PdfRect &, PdfDocument*, EPdfSignFieldSubFilter eSubFilter = ePdfSignFieldSubFilter_pkcs7detached ) has a default value. What's your opinion on this (not committed yet)? > These have no such response. > > There are also some ongoing questions, which might be fixed too, but > that's not the same as having pending patches. > > > do you think now it could be a good moment to go for it > > Sure, feel free to do it, I've no problem with that. My only concern > was about pending patches, but if you believe you addressed that, then > there's no other obstacle to do it, at least from my side. Please see above. > Thanks and bye, > zyx _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
