The comment absolutely states pre-existing bugs and no regressions are
introduced. I know it also because I fixed that exact issue in a
unsent patch.



On Tue, 18 Feb 2020 at 17:59, Michal Sudolsky <sudols...@gmail.com> wrote:
>
> Hi,
>
> There were added two "FIXME" comments like this:
>
> - if( rhs.m_pStream && m_pOwner )
> - m_pStream = m_pOwner->CreateStream( *(rhs.m_pStream) );
> + // FIXME:
> + // Copying stream is currently broken:
> + // 1) PdfVecObjects::CreateStream( const PdfStream & ) is broken as it just 
> returns NULL
> + // 2) Stream should be copyable also when m_pOwner is NULL (which is the 
> case for copy constructor)
> + //if( rhs.m_pStream && m_pOwner )
> + // m_pStream = m_pOwner->CreateStream( *(rhs.m_pStream) );
>
> Does this fix Introduce some new breakage or was such situation also before?
>
>


_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to