Also I personally think "FintAt" should also check index and return NULL if it is higher or equal to array size. In that way it would be easier to use it on many places and will be more akin to FindKey. Regarding performance impact this should be negligible because there it still need to check whether is returned value reference in contrast with faster operator[] of PdfArray (although also this operator checks for "mutability").
On Thu, Mar 5, 2020 at 9:04 PM Michal Sudolsky <sudols...@gmail.com> wrote: > Hi, > > Seems there is only one merge conflict due to r1990 which I think could be > fixed in better way by using new "FindAt" function or similar (I would > propose to add "MustFindAt" which would check that it does not return NULL > and also whether is index within array bounds). > > On Wed, Feb 26, 2020 at 8:57 AM zyx <z...@gmx.us> wrote: > >> On Mon, 2020-02-24 at 20:51 +0100, Francesco Pretto wrote: >> > I will not be able to fix the conflicts, re-test and commit the patch >> > myself for at least 2 weeks. >> >> Hi, >> that's okay, there is no hurry. I won't get to it sooner too. Unless >> you beat me I'll give it a try in around the similar time frame or >> slightly later (I'm also kind of behind PoDoFo development at the >> moment), say mid or the second half of this year's March (supposing >> nothing more urgent won't step in on my side). >> Thanks and bye, >> zyx >> >> >> >> _______________________________________________ >> Podofo-users mailing list >> Podofo-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/podofo-users >> >
_______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
