On Tue, 2023-01-24 at 01:30 +0100, Francesco Pretto wrote:
> PdfPainter::Arc() [2], without making use of previous
> SVG extension methods

        Hi,
what precise SVG extension method you've on mind, please? The
CubicBezierTo() uses a PDF `c` drawing operator, which is a standard
thing, it's nothing like SVG extension. The PDF standard does mention
SVG, but on very different places, and only sparingly.

I believe you do the best for the project, I appreciate it the same as
the others, it's a lot of work and energy you put into it, though, as
an Open Source project, might some decisions be made in public, not to
be just a single person decision? What if some parts are over
engineered? The PdfPainterExtensions sounds like one of them. For
example, the PdfPainterExtensions::HorizontalLineTo() should use the
position from the PdfPainter::MoveTo(), or the end of the
PdfPainter::LineTo(), simply the current position for the path, not the
last position being set by the other PdfPainterExtensions() functions,
right? Similarly the other PdfPainterExtensions functions change the
current position in the PDF's drawing context, but not for the
PdfPainter itself, which can cause trouble in some cases.

Just a quick "review" opinion.

        Bye,
        zyx


_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to