> hi,This this the patch file,this is my first use pathc/diff tools,since i
> used to program under win32. hope it will give someone some help.
Thanks for your work. It looks good to me, although some changes are
needed before it can be included in Polipo. Here's my review.
Please do not dispatch on #ifdef WIN32, as this will break compilation
under Cygwin.
Please do not use CC++-style comments, they break compilation under SYSV.
Please do not change the behaviour of Polipo -- if you want to make an
incompatible change, please make it into a separate patch and discuss it
on this list. There are good reasons why Polipo doesn't allow relative
paths in the web server's root directory, and why it doesn't silently
create the directory when it doesn't exist -- doing otherwise raises
some significant security issues.
Please do not include unrelated changes in your portability patch, send
a separate patch instead -- I've noticed the change to the ETag parser,
and the typo fix in object.c which don't belong in this patch, since
they are not specific to Windows.
The change to mktime_gmt is wrong -- an empty TZ variable is different
from no TZ variable at all.
Please remove the stdint.h emulation file. Instead, you should just
typedef my_uint32_t in md5import.c.
Please do not unconditionally remove the compatibility macro for va_copy.
What's Iphlpapi.lib? Will it break compilation under mingw?
Juliusz
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
