Thanks for your new patch. It's definitely getting there.
Chris, any opinions? Is that something you want to include?
In case you're interested, I think it would be a good thing to include,
although I'd recommend that the VC project files should *not* be
included, but distributed separately.
>> Please do not dispatch on #ifdef WIN32, as this will break compilation
>> under Cygwin.
> I've test it under Cygwin ,it works fine. There is not macro WIN32 under
> Cygwin.could you give me more detail's?
Sorry, you're right.
>> The change to mktime_gmt is wrong -- an empty TZ variable is different
>> from no TZ variable at all.
> [...] so i rewrite a new one for VC:
Excellent.
>> Please do not include unrelated changes in your portability patch, send
>> a separate patch instead
> I've accepted in the new patch.
You're still including some unrelated changes, notably the change to
object.c.
It would be easier for everyone if you could generate a set of patches,
each of which for one feature, rather than a single large patch. For
example, the renaming of mingw* to win32* is a good thing, that can go
in immediately, and I'd recommend making it into a separate patch.
If you find it tricky to manage sets of patches by hand, you can either
use git, as Gabriel recommended, or use quilt (which is a little bit
more difficult).
Other comments:
There's a bunch of files with Microsoft line endings (^M^J). Please use
Unix line endings (you may find the tool dos2unix useful, or you may
need to configure your editor differently).
There's a bunch of files with hard tabulations (^I); please use spaces
instead.
Please do not patch the Makefile -- see the README.Windows file.
Why do you rename the stat field in fts_compat? (That's a good example
of a change that you should submit in its own patch file, by the way.)
I'm opposed to the use of a relative pathname for DEFAULT_CONFIG_PATH.
Please do not patch md5.{c,h}, these are unmodified files. Please
modify md5import.{c,h} instead.
There's no copyright/licence on the dirent emulation. (You could work
around the issue by disabling the on-disk cache on Windows.)
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
