FWIW, it's possible to compare changes through GitHub without creating a
PR, by going to https://github.com/<org>/<repo>/compare/
Here is the diff of battleblow:jdk:bsd-port against openjdk:jdk:master
-> https://github.com/openjdk/jdk/compare/master...battleblow:jdk:bsd-port
Jorn
On 5-2-2025 02:25, David Holmes wrote:
Hi Harald,
On 31/01/2025 4:17 am, Harald Eilertsen wrote:
Hi,
I've been contracted by The FreeBSD Foundation to try to improve OpenJDK
support for the FreeBSD operating system. Currently the BSD port lives
in a separate github org over at https://github.com/battleblow, but we'd
like to make porting easier and more streamlined in the future by
submitting our changes to the mainline OpenJDK repo.
Currently I'm thinking the best approach is to submit small, self
contained patches adressing specific issues when trying to build on
FreeBSD. Both to make reviewing more manageable, but also to get
feedback so that we ensure the changes integrate as smoothly with the
OpenJDK project as possible.
Will it be best to create a JBS issue for each change, or one issue for
the entire effort?
Can you create a PR against mainline so that we can see the scope of
the changes and how they have been implemented? That would allow for a
technical appraisal of what is involved in supporting FreeBSD.
Knowing the technical scope would also aid evaluation of whether this
needs to be treated as a full porting project, or whether it can just
be accommodated the way we, for example, accommodate the MUSL libc
used on Alpine Linux. Is this a re-vamp of the BSD-port project [1] or
is this a distinct effort? I think the Porters Group [2] will need to
weigh-in on this either way (cc'd).
Thanks,
David
[1] https://openjdk.org/projects/bsd-port/
[2] https://openjdk.org/groups/porters/
Thanks in advance!
Harald Eilertsen
--
Eilertsens Kodeknekkeri
https://kodeknekkeriet.net
