Stuart, all, Sorry for missing this, and not replying sooner,
It might be worth doing a release for those running stable, and then adding in the fix with an ifdef Ill have a chat with Stefan, offline, On Wed, 25 Jun 2025 at 01:14, Stuart Henderson <[email protected]> wrote: > > quick heads-up, this change in base needs nsh to catch up. I didn't > check but I assume the existing code is going to be similar enough to > what's in usr.bin/netstat/mbuf.c that it should be easy to adapt. > > > ----- Forwarded message from Alexander Bluhm <[email protected]> ----- > > From: Alexander Bluhm <[email protected]> > Date: Sun, 22 Jun 2025 05:34:40 -0600 (MDT) > To: [email protected] > Subject: CVS: cvs.openbsd.org: src > > CVSROOT: /cvs > Module name: src > Changes by: [email protected] 2025/06/22 05:34:40 > > Modified files: > sys/kern : kern_sysctl.c uipc_mbuf.c uipc_mbuf2.c > sys/sys : mbuf.h > usr.bin/netstat: mbuf.c > > Log message: > Protect mbuf statistics counter with splnet. > > MP safe conters with per CPU memory still need spl protection when > called from interrupt context. Some increments of mbuf counters > had that, others did not. Introduce inline function mbstat_inc() > and enum counter types for mbufs, like we have elsewhere. With > that mbufs counter increment takes splnet() everywhere. > > OK mvs@ dlg@ > > > ----- End forwarded message ----- -- Kindest regards, Tom Smyth.
