On 2018/07/25 12:10, Elias M. Mariani wrote: > We are currently using pytest 3.5.0. > > Acording to pytest changelog: > "Pytest now captures and displays output from the standard logging > module. The user can control the logging level to be captured by > specifying options in pytest.ini, the command line and also during > individual tests using markers. Also, a caplog fixture is available > that enables users to test the captured log during specific tests > (similar to capsys for example). For more information, please see the > logging docs. This feature was introduced by merging the popular > pytest-catchlog plugin, thanks to Thomas Hisch. Be advised that during > the merging the backward compatibility interface with the defunct > pytest-capturelog has been dropped." > https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23 > > "The pytest-capturelog plugin is now also blacklisted, avoiding errors > when running pytest with it still installed." > https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-1-2017-12-05 > > So the plugin is not active even when devel/py-test-capturelog is > installed since version 3.3.1. > > Meaning: This is a useless plugin. Is not being used because it can't be used. > > Just to be 200% sure I tested the results with and without > py-test-capturelog (even when this shouldn't affect tests even if it > would be working, but to ease any doubts...). > > sqlite3 /usr/local/share/sqlports "select FULLPKGPATH from depends > where dependspath like '%devel/py-test-capturelog%';" > productivity/khal > > Test with capturelog: > 43 failed, 231 passed, 1 xfailed, 1 warnings > > Test without capturelog: > 43 failed, 231 passed, 1 xfailed > > The warning being: > "pytest-capturelog plugin has been merged into the core, please remove > it from your requirements." > > Find attached a diff containing the modified > productivity/khal/Makefile removing the test dependency on > devel/py-test-capturelog and the removal o devel/py-test-capturelog > > Cheers. > Elias.
Needs an entry in devel/quirks for the removal. No need to bump REVISION in productivity/khal, it doesn't affect the package. Otherwise OK with me
