On 2018/08/02 20:34, Jan Klemkow wrote: > Hi Rafael, > > On Thu, Aug 02, 2018 at 06:31:53PM +0200, Rafael Sadowski wrote: > > On Thu Aug 02, 2018 at 05:36:13PM +0200, Jan Klemkow wrote: > > > Hi Rafael, > > > > > > I also worked on an cmark port. I took your tar ball and fixed all > > > comments Stuart pointed out. Just, the MAINTAINER field is still unset, > > > But, a portscheck run does not require this field. > > > > > > I replaced the manual DISTFILE and MASTER_SITE handling by the GH_* > > > variables, moved it to category "textproc" and correct some spacing. > > > > That wasn't the way to go and the spacing was fine -- trust me or use > > vim. Please see my traball. > > You are right, I missed some spaces. But, I already used vim ;-) > > > > > > > Hopefully that helps you. I also need this tool for a private project > > > of mine. > > > > Would you like to take MAINTAINER? > > Yes, I can do that. See my attached tar ball. I removed a useless line > and replaced some spaces by tabs. And it uses the GH_* variables. > > Hope that's fine for all so far. > > Thanks, > Jan
DISTNAME isn't needed here, the one generated from GH_PROJECT and GH_TAGNAME is good anyway. OK sthen@
