On Wed, 30 Dec 2020 05:30:39 -0700
Thomas Frohwein wrote:
> On Mon, Dec 28, 2020 at 04:15:45PM -0500, Brad Smith wrote:
> > On 12/28/2020 11:14 AM, Charlene Wendling wrote:
> > > On Sat, 26 Dec 2020 15:03:07 -0500
> > > Brad Smith wrote:
> > >
> > > > On 12/25/2020 3:39 PM, Thomas Frohwein wrote:
> > > > > On Thu, Dec 24, 2020 at 09:48:45PM -0500, Brad Smith wrote:
> > > > > > Here is an update to SDL 2.0.14.
> > > > > >
> > > > > > Tested with a few apps. More testing and feedback welcome.
> > > > > I have a similar diff that I'm testing. A few releases ago,
> > > > > there was an issue with some reverse deps breaking during
> > > > > build.
> > > > >
> > > > > Brad, can you let me know what apps you tested, and if you
> > > > > tested build and/or runtime, so that I can add it into my own
> > > > > list of tests?
> > > > mpv
> > > > qemu
> > > > ffplay
> > > > blobby
> > > > taisei
> > > > supertux
> > > >
> > > > Run time testing. I just chose a couple of random games to do
> > > > some additional run time
> > > > testing of the video and audio output.
> > > >
> > > > I noticed supertux randomly crashes in SDL_BlitCopy upon
> > > > startup, but that is not new
> > > > for this release of SDL.
> > > >
> > > Hi,
> > >
> > > Some testing report:
> > >
> > > - amd64: i've tested emulators/ppsspp and games/endless-sky
> > > without issues, using my logitech dual action
> > > - macppc: after building that update, i've built and run tested
> > > games/wesnoth and games/blobby and everything is
> > > still fine
> > >
> > > Port-wise, that looks good to me.
> > Thanks.
>
> Generally looking good. I did some extensive testing with Brad's diff;
> see sdl2-testing-2.0.14.txt in attachments for a table of results.
>
> Build of emulators/vbam breaks with this update. It can't find
> KMOD_GUI variable anymore; and no KMOD_META. See vbam.txt attachment.
> I got a simple diff for the vbam port below that unbreaks this.
>
> Just double-checking - did SIMD support change with clang on arm (in
> Brad's diff)?
>
> -# clang can't handle simd asm
> -.if ${MACHINE_ARCH} == "arm"
> -CONFIGURE_ARGS+= --disable-arm-simd
>
> If this is clarified, ok thfr@ for Brad's sdl2 diff.
>
> ok for vbam fix below?
Oh, we still provide vbam while there is mgba around :(
I tested your diff with SDL 2.0.14, it builds fine, ok cwen@
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/emulators/vbam/Makefile,v
> retrieving revision 1.34
> diff -u -p -r1.34 Makefile
> --- Makefile 17 Nov 2019 00:14:36 -0000 1.34
> +++ Makefile 30 Dec 2020 12:23:16 -0000
> @@ -9,6 +9,7 @@ GH_ACCOUNT = visualboyadvance-m
> GH_PROJECT = ${GH_ACCOUNT}
> GH_TAGNAME = v2.1.4
> PKGNAME = vbam-${GH_TAGNAME:S/v//}
> +REVISION = 0
>
> CATEGORIES = emulators
>
> Index: patches/patch-src_sdl_SDL_cpp
> ===================================================================
> RCS file: patches/patch-src_sdl_SDL_cpp
> diff -N patches/patch-src_sdl_SDL_cpp
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-src_sdl_SDL_cpp 30 Dec 2020 12:23:16 -0000
> @@ -0,0 +1,15 @@
> +$OpenBSD$
> +
> +Index: src/sdl/SDL.cpp
> +--- src/sdl/SDL.cpp.orig
> ++++ src/sdl/SDL.cpp
> +@@ -876,9 +876,7 @@ void sdlInitVideo()
> +
> + sdlResizeVideo();
> + }
> +-#if defined(KMOD_GUI)
> + #define KMOD_META KMOD_GUI
> +-#endif
> +
> + #define MOD_KEYS (KMOD_CTRL | KMOD_SHIFT | KMOD_ALT | KMOD_META)
> + #define MOD_NOCTRL (KMOD_SHIFT | KMOD_ALT | KMOD_META)
