On Mon, Feb 08, 2021 at 05:00:54PM +0000, Stuart Henderson wrote:

> On 2021/02/08 08:39, Kurt Mosiejczuk wrote:

> > Here's a new port for lwjgl3. It's a new port since there are existing
> > things that use the lwjgl 2.x version we already have.

> ; 
> ; DISTFILES +=        ${DISTNAME}.tar.gz \
> ;             kotlin-compiler-1.3.61.zip:1 \

> can use a version variable here ^^

> ;             lwjgl3-maven.tar.gz:2

> might be better to add a version/date into that filename, as a clue to use
> a different name if/when it's updated

Good point.

> ; MASTER_SITES =      \
> ;     https://github.com/kmosiejczuk/lwjgl3/releases/download/3.2.4alpha1/

> and here ^^

Yeah. thfr@ pointed those out to me.


> ; pre-configure:
> ;     perl -pi -e 's,/usr/X11R6,${X11BASE},g' \
> ;             ${WRKSRC}/build.xml
> ;     perl -pi -e 's,/usr/local,${LOCALBASE},g' \
> ;             ${WRKSRC}/build.xml
> ;     mkdir -p ${WRKSRC}/bin/libs
> ;     touch ${WRKSRC}/bin/libs/touch.txt
> ;     unzip -oq -d ${WRKSRC}/bin/libs/ \
> ;             ${FULLDISTDIR}/kotlin-compiler-${KOTLIN_V}.zip
> ;     tar -C ${WRKSRC}/bin/libs -zxf ${FULLDISTDIR}/lwjgl3-maven.tar.gz

> i would prefer to do those unzip/tar in post-extract (doesn't matter
> hugely here i guess, but if it ever needs to be patched then it's in the
> right place)

Better to do it the right way to start. I've changed it.

> i'll go with "that isn't terrible". ;)
> also "it's way better than the 'process' i have for rebuilding snappy-java".

Why thank you. Much of the multi-distfile work was by or inspired by work
by phessler and pamela. Glad to hear it is not too gross. The intial testing
was done by saying "Here, shove these .jar files in this directory" :D

This is much better, I think. :D

--Kurt

Reply via email to