Hi,

On Tue, 13 Apr 2021, Stefan Hagen wrote:

> Hello,
> 
> Attached is hcloud, a cli tool written in go to manage virtual server 
> hosted in the Hetzner Cloud. (at https://console.hetzner.cloud)
> 
> Tool Homepage: https://github.com/hetznercloud/cli#readme
> API description: https://docs.hetzner.cloud
> 
> Hetzner is a very popular hoster. Debian, Ubuntu, Arch, Void, Gentoo,
> FreeBSD and others have imported this tool.
> 
> This is my first port generated with portgen. Is there anything I can 
> improve?

Just a couple of things:

Removed the initial 'a' from COMMENT

s/NO_TESTS/NO_TEST/

Removed a comment you had on go get ...  I don't know why that was there.

Also, we're in favor of putting the MODGO_MODULES hell in a separate
file and include it on the Makefile.

A part from that it works fine and the port looks good to me.  I'll
import it later this evening or tomorrow if there's no objection.

Cheers,

-- 
Paco Esteban.
0x5818130B8A6DBC03

Reply via email to