On 2021/12/29 08:22, Omar Polo wrote: > Aisha Tammy <openbsd.po...@aisha.cc> writes: > > > Hi, > > I've attached the patch for updates of usockets, uwebsockets and > > purritobin. > > > > Main build changes are in the net/usockets port where now I've > > replaced the Makefile by Makefile.obsd to keep things simple. > > Hello, > > I was just taking a look at the diff and noted that it got mangled :/ > > some quick comments: I don't use purritobin/usockets but these caught > the eye. > > > [...] > > -NO_TEST = Yes > > +# tests need A LOT of file desrciptors ~5000-6000 > > typo :) > > > [...] > > diff --git a/net/usockets/patches/patch-Makefile_obsd > > b/net/usockets/patches/patch-Makefile_obsd > > new file mode 100644 > > index 00000000000..d822e7933ae > > --- /dev/null > > +++ b/net/usockets/patches/patch-Makefile_obsd > > instead of adding a file with a patch against /dev/null, I think it's > easier to just add the makefile in files/Makefile and then, in > post-extract do
agreed, it makes diffs easier to read > ${INSTALL_DATA} ${FILESDIR}/Makefile ${WRKSRC} please use cp (or ${SUBST_CMD} -c if needed) for build steps, ${INSTALL_xxx} commands are for install steps