Klemens Nanni <k...@openbsd.org> wrote: > On Sat, Jun 25, 2022 at 10:39:33AM +0000, Klemens Nanni wrote: > > 4.0.0 with Qt5 works for me, so I'd like to commit this update soon. > > > > The Qt5 fix is added as qt5-patch-* such that a follow-up diff for the > > -qt5 flavour can set PATCH_LIST conditionally and thus avoid the Qt5 fix > > for the Qt6 build (if possible). > > > > Feedback? OK? > > > +PATCH_LIST += qt5-patch-* > > This did not add to the default list but defined it, so it removed > "patch-*" and thus broke configure. > > I did not notice that because I did > 1. make build > 2. see failure > 3. add patch > 4. make build > 5. add `PATCH_LIST += qt5-patch-*' to Makefile > 6. send diff > > Here's a working diff. > Thanks for op@ for mentioning the configure failure. > > Feedback? OK?
quickly tested, but everything seems to work (even calls) ok op@
