On 2022/07/25 09:48, Omar Polo wrote:
> some nits:
> 
>  - we've dropped the RCS Ids (the $OpenBSD$ line) in ports
>  - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per
>    Makefile.template
>  - no need to set MODPY_VERSION, that's already the default

agreed on these

> Personally, I'd go with a patch instead of sed -i for setup.py, but even
> using sed -i should be fine in this case.  (patches are more robust than
> sed for updates; they break sometimes, but at least you get the chance
> to see what's going on instead of blindling substituting.)

+1 for this

Reply via email to