On Sat, Dec 10, 2022 at 12:35 AM Volker Schlecht <openbsd-po...@schlecht.dev> wrote: > > FWIW, github user barrykn, who identified the bug now also confirmed > that it builds and works.
Hi, I'm github user barrykn!
It builds and works on amd64, but it fails to build on i386.
On i386 I get lots of errors like this:
In file included from
../deps/v8/src/libplatform/tracing/tracing-controller.cc:10:
In file included from ../deps/v8/src/base/atomicops.h:472:
../deps/v8/src/base/atomicops_internals_atomicword_compat.h:26:19:
error: redefinition of 'Relaxed_CompareAndSwap'
inline AtomicWord Relaxed_CompareAndSwap(volatile AtomicWord* ptr,
^
../deps/v8/src/base/atomicops.h:262:17: note: previous definition is here
inline Atomic64 Relaxed_CompareAndSwap(volatile Atomic64* ptr,
^
I have attempted a fix and am attaching it as a patch to your patch,
but I have not tested it yet; I won't be able to test it until
later today. (Also, this is the first time in many years that
I've sent a patch to a mailing list, so hopefully I won't mess this
up...)
I'll follow up with another email once I test this on both
amd64 and i386.
--
-Barry K. Nathan <bar...@pobox.com>
patch-for-node-v18.12.1.diff
Description: Binary data
