On Sat, Dec 10, 2022 at 5:05 AM Volker Schlecht
<openbsd-po...@schlecht.dev> wrote:
>
> Hi Barry,
>
> thanks! I noticed that www/chromium already removed a part of the patch
> to use the inline definition of Relaxed_CompareAndSwap.
>
> Unfortunately I don't have an i386 machine to test on, but wouldn't the
> attached variant fix the same issue?
Unfortunately it fails on i386, with different errors than last time. I've
included some of the errors below; they are all related to Relaxed_Load().
In file included from ../deps/v8/src/libplatform/tracing/tracing-controller.cc:1
0:
../deps/v8/src/base/atomicops.h:359:11: error: no matching function for call to
'Relaxed_Load'
Relaxed_Load(reinterpret_cast<const volatile AtomicWord*>(src)));
^~~~~~~~~~~~
../deps/v8/src/base/atomicops.h:225:16: note: candidate function not viable: no
known conversion from 'const volatile v8::base::AtomicWord *' (aka 'const volati
le long *') to 'const volatile v8::base::Atomic8 *' (aka 'const volatile char *'
) for 1st argument
inline Atomic8 Relaxed_Load(volatile const Atomic8* ptr) {
^
../deps/v8/src/base/atomicops.h:230:17: note: candidate function not viable: no
known conversion from 'const volatile v8::base::AtomicWord *' (aka 'const volati
le long *') to 'const volatile v8::base::Atomic16 *' (aka 'const volatile short
*') for 1st argument
inline Atomic16 Relaxed_Load(volatile const Atomic16* ptr) {
^
../deps/v8/src/base/atomicops.h:235:17: note: candidate function not viable: no
known conversion from 'const volatile v8::base::AtomicWord *' (aka 'const volati
le long *') to 'const volatile v8::base::Atomic32 *' (aka 'const volatile int *'
) for 1st argument
inline Atomic32 Relaxed_Load(volatile const Atomic32* ptr) {
^
../deps/v8/src/base/atomicops.h:399:11: error: no matching function for call to
'Relaxed_Load'
Relaxed_Load(reinterpret_cast<const volatile AtomicWord*>(src)));
^~~~~~~~~~~~
../deps/v8/src/base/atomicops.h:225:16: note: candidate function not viable: no
known conversion from 'const volatile v8::base::AtomicWord *' (aka 'const volati
le long *') to 'const volatile v8::base::Atomic8 *' (aka 'const volatile char *'
) for 1st argument
etc.
(By the way, the patch from my previous email worked for me on both
amd64 and i386.)
I'm open to testing more patches on i386, however today is likely
to be a busy day for me, so there's a chance that I won't have time
for more testing until tomorrow.
--
-Barry K. Nathan <bar...@pobox.com>
