On Tue, Jan 10 2023, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > On Sun, Jan 08 2023, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > > [...] > >>> https://wxcvbn.org/~jca/build-failures/amd64-clang/2023-01-03/x11/xloadimage.txt >> tiff.c:234:18: error: incompatible integer to pointer conversion passing >> 'int' to parameter of type 'char *' [-Wint-conversion] >> tiff = is_tiff(fullname, name, &info); > > ok? I can add a REVISION bump if you prefer.
-current clang already warns about this, I think a REVISION bump would be appropriate. My diff had a typo, fixed in my tree (thx gnezdo@) > llvm 15 test material: > git branch: https://github.com/jcourreges/openbsd-src/tree/llvm15-6 > amd64 snaps: https://pbuild-amd64.wxcvbn.org/pub/OpenBSD/snapshots/amd64/ > > Index: patches/patch-tiff_c > =================================================================== > RCS file: patches/patch-tiff_c > diff -N patches/patch-tiff_c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-tiff_c 9 Jan 2023 15:30:30 -0000 > @@ -0,0 +1,15 @@ > +Bare minimum for clang 15 to get type information and avoid invalid integer ^ > +to pointer conversion. > + > +Index: tiff.c > +--- tiff.c.orig > ++++ tiff.c > +@@ -227,6 +227,8 @@ static void babble(name, info) > + } > + > + int tiffIdent(fullname, name) > ++ char *fullname; > ++ char *name; > + { > + TIFF *tiff; > + struct tiff_info info; -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
