On Sun, Jan 08 2023, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> On Sun, Jan 08 2023, Jérémie Courrèges-Anglas <j...@wxcvbn.org> wrote:
>> Bulk build on pbuild-amd64.wxcvbn.org
>>
>> Started : Tue Jan  3 02:26:11 CET 2023
>> Finished: Sat Jan  7 01:45:02 CET 2023
>> Duration: 3 Days 23 hours 19 minutes
>>
>> Built using OpenBSD 7.2-current (GENERIC.MP) #2: Fri Dec 30 02:11:28 CET 2022
>>
>> Built 10508 packages
>>
>> Number of packages built each day:
>> Jan 3: 3984
>> Jan 4: 1693
>> Jan 5: 1731
>> Jan 6: 3094
>> Jan 7: 6
>>
>>
>> Critical path missing pkgs:
>> https://wxcvbn.org/~jca/build-failures/amd64-clang/2023-01-03/summary.txt
>>
>> Build failures: 132
>
> Summary of the warnings involved in the failures:
>
> -Wint-conversion: 98
> -Werror,-Wstrict-prototypes: 8
> -Werror,-Wunused-but-set-variable: 1
> -Werror,-Wbitwise-instead-of-logical: 1
> -Werror,-Winvalid-utf8: 1
> -Werror,-Wgnu-null-pointer-arithmetic: 1
> -Werror,-Wdocumentation: 1
> -Werror,-Wdeprecated-non-prototype: 1
>
> Errors excerpt:

[...]

>> https://wxcvbn.org/~jca/build-failures/amd64-clang/2023-01-03/x11/mplayer.txt
> libmpcodecs/ve_lavc.c:444:39: error: incompatible integer to pointer 
> conversion assigning to 'RcOverride *' (aka 'struct RcOverride *') from 'int' 
> [-Wint-conversion]
>         lavc_venc_context->rc_override=
>                                       ^

Looks like an API usage error, the diff below fixes it.  It doesn't do
more, like adding error checking (if desirable, please address that in
a subsequent diff).  ok?

llvm 15 test material:
git branch: https://github.com/jcourreges/openbsd-src/tree/llvm15-6
amd64 snaps: https://pbuild-amd64.wxcvbn.org/pub/OpenBSD/snapshots/amd64/


Index: x11/mplayer/Makefile
===================================================================
RCS file: /home/cvs/ports/x11/mplayer/Makefile,v
retrieving revision 1.322
diff -u -p -r1.322 Makefile
--- x11/mplayer/Makefile        4 Dec 2022 20:12:36 -0000       1.322
+++ x11/mplayer/Makefile        11 Jan 2023 22:05:27 -0000
@@ -3,7 +3,7 @@ COMMENT=        movie player supporting many fo
 V=             20211106
 FFMPEG_V=      4.4.3
 DISTNAME=      mplayer-${V}
-REVISION=      3
+REVISION=      4
 CATEGORIES=    x11 multimedia
 MASTER_SITES=  https://comstyle.com/source/
 EXTRACT_SUFX=  .tar.xz
Index: x11/mplayer/patches/patch-libmpcodecs_ve_lavc_c
===================================================================
RCS file: x11/mplayer/patches/patch-libmpcodecs_ve_lavc_c
diff -N x11/mplayer/patches/patch-libmpcodecs_ve_lavc_c
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ x11/mplayer/patches/patch-libmpcodecs_ve_lavc_c     11 Jan 2023 22:04:58 
-0000
@@ -0,0 +1,14 @@
+av_reallocp_array and av_realloc_array are not the same functions.
+
+Index: libmpcodecs/ve_lavc.c
+--- libmpcodecs/ve_lavc.c.orig
++++ libmpcodecs/ve_lavc.c
+@@ -442,7 +442,7 @@ static int config(struct vf_instance *vf,
+             return 0;
+         }
+         lavc_venc_context->rc_override=
+-            av_reallocp_array(lavc_venc_context->rc_override, i+1, 
sizeof(*lavc_venc_context->rc_override));
++            av_realloc_array(lavc_venc_context->rc_override, i+1, 
sizeof(*lavc_venc_context->rc_override));
+         lavc_venc_context->rc_override[i].start_frame= start;
+         lavc_venc_context->rc_override[i].end_frame  = end;
+         if(q>0){



-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Attachment: signature.asc
Description: PGP signature

Reply via email to