On 2023/02/27 18:34, Volker Schlecht wrote: > On 2/27/23 11:00, Stuart Henderson wrote: > > On 2023/02/17 22:55, Volker Schlecht wrote: > > > Cc: Maintainer > > > > > > Currently math/rstudio always reports > > > > > > "Unable to set a secure (HTTPS) download.file.method (no > > > compatible method available in this installation of R)." > > > > > > at startup, which based on a sample size of one (me), may be > > > confusing to users and take quite a while to track down. > > > > > > The attached patch > > > > > > * adds a RUN_DEPENDS on net/curl > > > * adds a patch for RStudio to default to curl as default > > > download method for OpenBSD, just as for Darwin and Linux. > > > > Can it use ftp(1) from base instead? That would be preferable. > > I didn't review all of it, but AFAICT, math/rstudio delegates the actual > download to math/R's download.file() / install.packages() functions and > doesn't shell out to curl. math/R handles file downloads via libcurl which > already pulls in net/curl: > > https://svn.r-project.org/R/trunk/src/modules/internet/internet.c > > While I don't fully understand the history and reasons for what's happening > in SessionPackages.R, it looks to me that this warning about non-TLS-capable > download methods is mainly intended for some Windows setups and possibly(?) > older versions of R, with OpenBSD being collateral damage of the assumption > that math/rstudio will only run on Windows, MacOS or GNU/Linux: > > https://github.com/rstudio/rstudio/blob/2df658bf8d2b1c34b2543b2858a9f1add0c65e0b/src/cpp/session/modules/SessionPackages.R#L1377
Ah, looking at that file note the difference between "curl" and "libcurl", it seems that it tries to use libcurl first and then there are fallbacks to use wget/curl binaries. So it seems the lines you patched wouldn't have been reached in the first place if libcurl detection was working properly?
