Le Thu, Apr 13, 2023 at 06:30:15PM +0200, Joel Carnat a écrit :
> Le 20/02/2023 à 10:19, Joel Carnat a écrit :
> > Hi,
> >
> > I’ve spend part of the weekend trying to solve the Firefox / Thunderbird
> > issue. In details, those applications can’t be docked and don’t get their
> > icon displayed. Long story short: I couldn’t solve it.
> >
> > I tried docklike on a couple of Linux distro and could reproduce the bug.
> > Only MX Linux doesn’t get the bug. But when getting its source and compile
> > on OpenBSD, the bug is still there.
> >
> > I’ll continue digging and let you know if I can find a solution.
> >
> > Regards,
> > Joel C.
> >
> > > Le 18 févr. 2023 à 15:02, Landry Breuil <lan...@openbsd.org> a écrit :
> > >
> > > Le Sat, Feb 18, 2023 at 01:44:20PM +0000, Klemens Nanni a écrit :
> > > > 2/18/23 13:16, Landry Breuil пишет:
> > > > > i havent tested it yet, but here's a port of the latest git commit,
> > > > > with
> > > > > a simplified Makefile.
> > > >
> > > > Do you intend to upstream the local patches? I was surprised to see
> > > > them given your use of XFCE4_COMMIT.
> > >
> > > i think joel wanted to upstream them :)
> > >
> > > > COMMENT must not start with articles or end in a full stop, I think.
> > >
> > > Right
> > >
> > > > Should this be hooked up to one of the xfce meta packages?
> > >
> > > Maybe, if it works and is useful..
> > >
> >
>
> Hi,
>
> xfce4-docklike has been updated upstream and we don't need any patches any
> more. Attached is the updated port. I've been using it on OpenBSD 7.3 amd64
> for a couple of days now without issue.
nice, two comments:
- no need for CONFIGURE_STYLE, its set by x11/xfce4/Makefile.inc
- please dont start COMMENT by an article, the previous one was fine imo
('modern & minimalist taskbar for Xfce') - no need for the final dot
either
other than that the port looks okay to me, i'll need another okay to
import it.
> I have also solved the "icons" issue I had with Firefox and Thunderbird.
> Basically, it is because the binaries are known as firefox-default and
> thunderbird-default in OpenBSD - I noticed this while running Windowmaker
> and docking those apps. I had to write my own
> ~/.local/share/applications/{firefox,thunderbird}.desktop files. And it also
> works to apply an icon to xterm(1). Do you think this package should come
> with a note about desktop files in MESSAGE or I should rather add those
> desktop files in the port?
I wont accept such desktop files in the docklike port, feels like a
kludge to workaround something broken somewhere else. What's the
difference between your desktop file and the original one ? There are no
'default' suffixes in the thunderbird/firefox binaries.. that has to be
some weird ICCCM property, because xprop on a firefox window indeed
gives WM_CLASS(STRING) = "Navigator", "firefox-default"
but i dunno where that comes from. Will have to dig.
How about xterm ?
Landry
