I’m starting to look this over. Thanks for working on it.
A few initial suggestions.

I think CATEGORY = graphics makes sense as the primary category
for this. The reason we try to avoid putting ports in the java
category as primary is essentially we don’t do it for any other
language - e.g. we don’t have python, rust, or go categories
and put all python, rust or go programs in there.

DESCR could be better. I yanked this from the javafx reference
manual - feel free to use that or adjust it:

  JavaFX is a set of graphics and media packages that enables
  developers to design, create, test, debug, and deploy rich
  client applications that operate consistently across diverse
  platforms.

I agree with the no ‘+’ on MODJAVA_VER and think your idea to
accommodate multiple versions is good. Perhaps
graphics/openjfx21 makes sense instead of another directory
layer. Along the same lines in order to avoid conflicts with
other OpenJFX versions, installing the jars into
$MODJAVA_JAR_DIR/openjfx21/ would work nicely.

Best,
-Kurt

> On Oct 5, 2026, at 3:44 PM, Sebastian Reitenbach 
> <[email protected]> wrote:
> 
> Hi,
> 
> here's an updated version, that stores the unversioned jars into 
> $MODJAVA_JAR_DIR, as suggested for other ports.
> Also removed the leftover  do-install-not-anymore: target.
> I just found the other day, that openjfx MAJOR version is supposed to match 
> JDK Major version or JDK Major version -1, as stated here: 
> https://wiki.openjdk.org/spaces/OpenJFX/pages/8257548/Building+OpenJFX#BuildingOpenJFX-OpenJDK
>  Therefore MODJAVA_VER=21
> Now with that figured, I wonder, if it would be a good idea to add 
> java/openjfx/21 directory, to accommodate for multiple versions in parallel 
> in the future?
> 
> cheers,
> Sebastian
> 
> On Mon, Sep 28, 2026 at 7:54 PM Kurt Mosiejczuk <[email protected]> wrote:
> On Thu, Sep 24, 2026 at 05:06:54PM +0200, Sebastian Reitenbach wrote:
> 
> > attached updated version using FULLDISTDIR in the patch and SUBST_CMD it
> > before building works for me.
> 
> > Does it work for you as well?
> 
> This works and build for me.
> 
> ok kmos
> 
> --Kurt
> 
> 
> -- 
> https://buzzdeee.reitenba.ch
> <openjfx.tar.gz>

Reply via email to