Re: port-lib-depends-check doesn't use quoting?

[Antti Harri]

On Mon, 18 Feb 2008, Marc Espie wrote:

Unfortunately, this fix is incomplete. Notice the 2>/dev/null ?
That's the reason why I haven't yet fixed it properly on my side...

Thanks for pointing it out.

New fix attached.

Again made by Johan Kiviniemi and lightly tested by me :-)

Index: check-lib-depends
===================================================================
RCS file: /cvs/ports/infrastructure/package/check-lib-depends,v
retrieving revision 1.13
diff -u -r1.13 check-lib-depends
--- check-lib-depends   27 Oct 2007 22:15:28 -0000      1.13
+++ check-lib-depends   19 Feb 2008 04:19:55 -0000
@@ -397,9 +397,12 @@
        my $n = shellquote($source->retrieve($item));
        my $cmd;
        if ($main::opt_o) {
-               open($cmd, "ldd -f 'NEEDED lib%o.so.%m.%n\\n' $n|");
+               open($cmd, "-|", "ldd", "-f", "NEEDED lib%o.so.%m.%n\n", $n) or die 
"open: $!";
        } else {
-               open($cmd, "objdump -p $n 2>/dev/null|");
+               unless (open($cmd, '-|')) {
+                       open(STDERR, '>', '/dev/null');
+                       exec('objdump', '-p', $n) or die "exec: $!";
+               }
        }
        my @l;
        while(my $line = <$cmd>) {