Re: port-lib-depends-check doesn't use quoting?

[Antti Harri]

Hi,

with the previous fix shellquote() is unnecessary, in fact
it now breaks checking on files that it escapes.

Noticed by Johan Kiviniemi.

Index: check-lib-depends
===================================================================
RCS file: /cvs/ports/infrastructure/package/check-lib-depends,v
retrieving revision 1.14
diff -u -r1.14 check-lib-depends
--- check-lib-depends   19 Feb 2008 11:02:53 -0000      1.14
+++ check-lib-depends   20 Feb 2008 05:05:39 -0000
@@ -359,12 +359,6 @@

 package OpenBSD::PackingElement::FileBase;
 use File::Basename;
-sub shellquote
-{
-       local $_ = shift;
-       s/[*?;() #\\'"`\${}]/\\$&/g;
-       return $_;
-}

 sub find_libs
 {
@@ -394,7 +388,7 @@
                $source->skip($item);
                return;
        }
-       my $n = shellquote($source->retrieve($item));
+       my $n = $source->retrieve($item);
        my $cmd;
        if ($main::opt_o) {
                open($cmd, "-|", "ldd", "-f", "NEEDED lib%o.so.%m.%n\n", $n) or die 
"open: $!";