On Wednesday 23 September 2009 02:01:27 Benoit Lecocq wrote: > Brad wrote: > > On Tuesday 22 September 2009 09:15:22 Benoit Lecocq wrote: > >> Hi, > >> > >> This diff updates check to the latest release 0.9.7. > >> Tested on amd64/sparc64. > >> > >> Comments ? OK ? > >> > >> Cheers, > >> benoit > > > > Your use of CPPFLAGS/LDFLAGS is wrong. Also why is this being added? I > > see no new external dependencies. > > File : check-0.9.7/NEWS > > ... > * support running tests with multiple pthreads (Daniel Gollub, closes > 1391527) > ... > > A "make" without CFLAGS/LDFLAGS : > > ../src/.libs/libcheckinternal.a(check_pack.o)(.text+0x445): In function > > `ppack': > : undefined reference to `pthread_mutex_lock' > > ../src/.libs/libcheckinternal.a(check_pack.o)(.text+0x463): In function > > `ppack': > : undefined reference to `pthread_mutex_unlock' > > collect2: ld returned 1 exit status > *** Error code 1 > > > I will make a new diff without the use of pthread.
I have no problem with using pthreads. That's just not the correct way of doing things. Why did you add the additional paths to CPPFLAGS / LDFLAGS? There might be a legitimate reason but I see no new additional dependencies that would explain why. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
