On 03/07/11 5:05 AM, Jan Stary wrote:
This diff is to make sure that ffmpeg doesn't create
hidden dependencies when opencore-amr is installed.
As I said in my other post this is not necessary.
On Jul 01 19:08:47, Brad wrote:
graphics/ffmpeg
ffmpeg's configure recognizes
--enable-libopencore-amrnb
--enable-libopencore-amrwb
which default to [no] (but shouldn't ffmpeg's CONFIGURE_ARGS say
--disable-libopencore-amrnb
--disable-libopencore-amrwb
explicitly if it doesn't use it?).
No.
Currently, the output of ffmpeg's configure just says
libopencore-amrnb support no
libopencore-amrwb support no
even with opencore-amr installed and seems to ignore it
(unlike other stuff, whose --enable-* defaults to [autodetect])
That's fine.
Quoting from the porting guide:
Identify missing software
Some dependencies won't be fulfilled because the missing
software has not yet been ported. It is highly recommended to
explicitly disable those options. Failure to do that breaks bulk
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
builds all the time: people port new software and import it, and
soon after, old ports stop building because they detect the
dependency, try to use it, and fail to build or package.
And:
* Document dependencies. Especially the stuff you don't use. Some
ports can use external software that may not be available at the
time of porting. Make sure you do not pick it up, and document it,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
so that you can update your port when this software becomes
available later.
Also:
* Changes to make sure a port does not pick/does pick an external
dependency warrant a bump.
That's why I think this diff is correct:
Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/ffmpeg/Makefile,v
retrieving revision 1.73
diff -u -p -r1.73 Makefile
--- Makefile 24 Jun 2011 11:16:21 -0000 1.73
+++ Makefile 3 Jul 2011 08:21:18 -0000
@@ -5,7 +5,7 @@ COMMENT= audio/video converter and strea
V= 20110408
DISTNAME= ffmpeg-git-${V}
PKGNAME= ffmpeg-${V}
-REVISION= 1
+REVISION= 2
CATEGORIES= graphics multimedia
MASTER_SITES= http://comstyle.com/source/
@@ -73,6 +73,8 @@ CONFIGURE_STYLE= simple
CONFIGURE_ARGS+= ${CONFIGURE_SHARED} \
--arch=${FFMPEG_ARCH} \
--cc=${CC} \
+ --disable-libopencore-amrnb \
+ --disable-libopencore-amrwb \
--disable-altivec \
--disable-armv5te \
--disable-armv6 \
Tested on amd64 and i386. ffmpeg has its own AMR code which it seems
to use: built with the patch above (without opencore-amr) it does
correctly recognize, play, and recode *.amr files.
Comments?
Jan
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
