On Sun, Sep 04, 2011 at 08:50:28PM +0200, Donovan Watteau wrote:
> It seems that, for an unknown reason, CONFIG_TREMOR doesn't get enabled.
> Could you do a simple "make configure", and then provide the content of
> config/tremor.h, "grep TREMOR config.mk" and "grep VORBIS config.mk"?
$ cat config/tremor.h:
#ifndef CONFIG_TREMOR_H
#define CONFIG_TREMOR_H
#define CONFIG_TREMOR 1
#endif
$ grep -E TREMOR\|VORBIS config.mk
CONFIG_VORBIS = n
> I guess you have audio/tremor installed?
Yes.
> Maybe the detection of Tremor is handled better if we don't explicitly
> set CONFIG_TREMOR/CONFIG_VORBIS. But, reading the ./configure script,
> I think we *do* need to set these variables, but I might have
> misunderstood that...
Without those, I get
$ cat config/tremor.h
#ifndef CONFIG_TREMOR_H
#define CONFIG_TREMOR_H
/* #define CONFIG_TREMOR */
#endif
$ grep -E TREMOR\|VORBIS config.mk
VORBIS_CFLAGS = -I/usr/local/include
VORBIS_LIBS = -L/usr/local/lib -lvorbisfile -lvorbis -lm -logg
CONFIG_VORBIS = y
I still think this should be imported *without* the arm-specific
tweaks and then fixed later, probably upstream. After all, what's
the purpose of that (non-autoconf) configure stuff? It's not as
broken by design as autoconf, but it's still complicated (and
broken).
Ciao,
Kili
