On May 07 11:36:30, Antoine Jacoutot wrote:
> On Mon, May 07, 2012 at 11:24:36AM +0200, Jan Stary wrote:
> > On May 07 09:44:36, Stuart Henderson wrote:
> > > surprised we didn't have this already. it does more than just adjust
> > > line-endings so I think it is actually useful. ok?
> > >
> > > ...
> > >
> > > Information for inst:dos2unix-6.0
> > >
> > > Comment:
> > > convert DOS/MAC files to UNIX (line-endings/charset)
> > >
> > > Description:
> > > Convert text files with DOS or Mac line breaks to Unix line breaks and
> > > vice versa. Features:
> > >
> > > * Automatically skips binary and non-regular files.
> > > * In-place, paired, or stdio mode conversion.
> > > * Keep original file dates option.
> > > * 7-bit and iso conversion modes like SunOS dos2unix.
> > > * Conversion of Windows UTF-16 files to Unix UTF-8.
> > >
> > > Maintainer: The OpenBSD ports mailing-list <ports@openbsd.org>
> > >
> > > WWW: http://waterlan.home.xs4all.nl/dos2unix.html
> > >
> >
> > I don't think this is right:
> >
> > post-install:
> > mv ${PREFIX}/share/man/* ${PREFIX}/man/
> > rmdir ${PREFIX}/share/man
> >
> > The orig Makefile should be patched instead to have
> >
> > mandir = $(prefix)/man
> > man1dir = $(mandir)/man1
> >
> > and install there.
>
> What is the benefit? Using sthen's method we can save a patch.
We need to patch the orig Makefile anyway,
and this makes the port's Makefile simpler.
> > Also, the mv line moves all man directories of all packages
> > that have installed there, which is none of its bussines.
>
> Huh? I think you are totally confused :)
That's well possible.
Let's say I have /usr/local/share/man/man1/prog.1
(however it got there from some third-site, unported software).
Now I make install dos2unix. The post-install portion
of Stuart's Makefile moves prog.1 which it has nothing
to do with. Is that correct?
Oh. This happens in the fake prefix, right? Excuse moi.
Jan
