On Mon, Nov 19, 2012 at 02:07:04PM +0000, Stuart Henderson wrote:
> On 2012/11/15 12:15, James Turner wrote:
> > On Thu, Nov 15, 2012 at 04:46:25PM +0000, Stuart Henderson wrote:
> > > On 2012/11/15 09:17, James Turner wrote:
> > > > Install notice:
> > > > After spiped is installed, you have to create a pre-shared secret key
> > > > and put the result in /etc/ssh/spiped.key.
> > > 
> > > Putting this in /etc/ssh seems a slightly odd choice?
> > > 
> > > | ../lib/events/events_network.c:222: warning: incompatible implicit 
> > > declaration of built-in function 'memset'
> > > 
> > > This is missing header:
> > > 
> > > #include <string.h>
> > > 
> > 
> > Attached is an updated port with the above patch. I've also moved
> > spiped.key to /etc/spiped. Does that make more sense? The
> > directory will be empty otherwise.
> 
> Thanks - a couple of tweaks:-
> 
> - run as a separate uid (requires a separate directory
> for the pid file done in rc_pre())
> 
> - protect the directory holding spiped's key (mode 750 root/_spiped)
> 
> - auto-create the key if it doesn't exist; done in rc_pre()
> 
> - patch /etc/ssh/spiped.key path in README
> 
> - don't use NO_CONFIGURE, this doesn't exist
> 
> - do use NO_REGRESS
> 
> 
> OK with you James?
> Any OKs to import this?
> 

All these changes sound great to me. I tested again on amd64. I did have
to make a small tweak the perl regex, it was missing the terminating
comma. Updated port with that tweak attached.

-- 
James Turner
ja...@calminferno.net

Attachment: spiped.tgz
Description: application/tar-gz

Reply via email to