Vadim Zhukov <persg...@gmail.com> writes: > 2014/1/7 Mikolaj Kucharski <miko...@kucharski.name>: >> Ping. Port at: >> >> http://marc.info/?l=openbsd-ports&m=138614602418802&w=2 >> >> On Wed, Dec 04, 2013 at 08:33:23AM +0000, Mikolaj Kucharski wrote: >>> Hi, >>> >>> I've incorporated some Debian patches, via Dag Wieers's src.rpm (also in >>> Gentoo[1]). I don't use nor need TK version of the script, so I've >>> disabled it. I've looked into it though and configure doesn't handle >>> detection well enough. I think it can go as is, without xdeview. >>> >>> Comment: >>> program for uu/xx/Base64/BinHex/yEnc de/encoding >>> >>> Description: >>> This is a powerful program at which you can throw a mess of unordered >>> files in any of BinHex, uuencoded, xxencoded, Base64 or yEnc formats >>> and expect them all to be properly decoded. These formats are >>> frequently encountered when sending binary files via news or mail. >>> >>> WWW: http://www.fpx.de/fp/Software/UUDeview/ >>> >>> >>> References: >>> 1. >>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/uudeview/files/ > > Two small nits: > > 1) License marker should be "GPLv2+, with BSDL parts" or like - check > the actual sources. > > 2) The "uu/xx/Base64/BinHex/yEnc decoder and encoder" looks a bit more > readable to me (non-native English reader), but no pressure here. :) > > After this, okay zhuk@ (I don't like the actual code playing with > fgetc(3) and ungetc(3), but that's a totally different story).
I took a look at it yesterday evening, and I don't think it is OK. The Debian patches add some good things (eg. use mkstemp) but they are also adding C11 code that 1. has no relevance on OpenBSD 2. looks completely broken. -- jca | PGP: 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE (previous: 0x06A11494 / 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494)
