cleaning up my inbox I found this not yet in ports. Sorry if I missed
something...
Bye, Marcus
lan...@rhaalovely.net (Landry Breuil), 2013.12.02 (Mon) 21:30 (CET):
> On Mon, Dec 02, 2013 at 06:59:40PM +0100, Tommy Scheunemann wrote:
> > On Sat, 30 Nov 2013 00:16:24 +0000 (UTC)
> > na...@mips.inka.de (Christian Weisgerber) wrote:
> >
> > > Landry Breuil <lan...@rhaalovely.net> wrote:
> > >
> > > > > For the .1x - AfterStep uses the format though if that is
> > > > > unwanted I can modify the upstream source and use .1 as extension.
> > > >
> > > > I have no idea how our man handles this -
> > >
> > > It handles it just fine. See x11/afterstep and a number of other
> > > ports that use this naming scheme.
> >
> > Hello,
> >
> > attached with the changes related to installing docs and samples, but
> > without the manpage renaming.
> > If that is still wished, it can be easily changed.
> >
> > Anything else that should be changed from my side ?
>
> There are still some things to polish:
> - make port-lib-depends-check shows that WANTLIB=c is missing.
> - you could aswell use
> ${INSTALL_DATA} ${WRKSRC}/{README,COPYING,TODO} ${PREFIX}/share/doc/wmconfig
> instead of cd ${WRKSRC} (but that's really cosmetic)
> - using INSTALL_DATA to copy stuff from SYSCONFDIR/wmconfig to
> share/examples leaves the files behind in SYSCONFDIR, and thus make
> update-plist will still complain. Since you're using automake/autoconf,
> you can use FAKE_FLAGS as a trick to tell make to install where you
> want.
>
> Try with:
> FAKE_FLAGS = sysconfdir=${PREFIX}/share/examples
> post-install:
> ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/wmconfig
> ${INSTALL_DATA} ${WRKSRC}/{README,COPYING,TODO}
> ${PREFIX}/share/doc/wmconfig
>
> simpler, cleaner :)
>
> Last nit: manpage says 'wmconfig will read all the files located in
> /usr/local/etc/wmconfig.' (and also refers to the same path in 3 spots)
> this should be fixed for correctness, but i dont really see how to fix
> that properly in the generated Makefile, so maybe only using a perl -pi
> -e 's#usr/local/##' ${PREFIX}/share/man/man1/wmconfig.1x line in
> post-install would do the trick.
>
> Other than those details, looks good to me, and if anyone wants to
> import it i'm ok with it.
>
> Landry
>
>
> !DSPAM:529cedfd74974631537411!
>
