Hello Edd, hello Stuart,

at the moment vim plugins can't depend on a language specific flavor of
vim like ruby or python, because the vim port's Makefile expects
exactly one gui (no_x11, gtk2, athena, motif) flavor. We don't want to
specify the gui flavor in the depending port because that would
disallow any other gui flavor.
Below is a diff against Edd's vim-command-t port and against the CVS
vim port that remedies the problem by setting a default gui flavor when
no gui flavor (but other flavors) were specified.

is the vim part ok ?

Christopher


On Sun, 7 Sep 2014 19:07:53 +0200 Christopher Zimmermann
<chr...@openbsd.org> wrote:

> On Sun, 7 Sep 2014 12:58:53 +0100 Edd Barrett <vex...@gmail.com> wrote:
> 
> > Hi Chris,
> > 
> > I think what you are proposing might help with a problem I was having
> > with vim-command-t. Can you comment?
> > 
> > http://marc.info/?l=openbsd-ports&m=140395978427546&w=2

* Vim dependency is too strong. Is there a way to express "any vim
  package including the ruby FLAVOR?"

This would work:

--- /tmp/vim-command-t/Makefile Sat Jun 28 14:30:24 2014                        
    
+++ Makefile    Sun Sep  7 21:50:04 2014
@@ -29,8 +29,8 @@
 
 # XXX Dependency too strong. Any flavor with ruby will suffice.
 # Is there a way to express that?
-BUILD_DEPENDS =                editors/vim,ruby,gtk2,python,perl
-RUN_DEPENDS =          ${BUILD_DEPENDS}
+BUILD_DEPENDS =                editors/vim
+RUN_DEPENDS =          vim-*-ruby:editors/vim,ruby
 
 NO_TEST =              Yes
 WRKDIST =              ${WRKDIR}/.vim


with this change in vim:

Index: Makefile
===================================================================
RCS file: /cvs/ports/editors/vim/Makefile,v
retrieving revision 1.139
diff -u -p -r1.139 Makefile
--- Makefile    7 Sep 2014 19:24:48 -0000       1.139
+++ Makefile    7 Sep 2014 20:06:48 -0000
@@ -34,9 +34,12 @@ FULLPKGNAME-lang= vim-lang-${VERSION}
 FULLPKGPATH-lang= ${PKGPATH},-lang
 
 FLAVORS=       huge gtk2 athena motif no_x11 lua perl python python3 ruby
-FLAVOR?=       gtk2
+FLAVOR?=
 
 .include <bsd.port.arch.mk>
+.if !${FLAVOR:Mno_x11} && !${FLAVOR:Mmotif} && !${FLAVOR:Mathena} && 
!${FLAVOR:Mgtk2}
+FLAVOR +=      gtk2
+.endif
 .if ${FLAVOR:Mno_x11}
 BUILD_PACKAGES := ${BUILD_PACKAGES:N-lang}
 .endif


-- 
http://gmerlin.de
OpenPGP: http://gmerlin.de/christopher.pub
F190 D013 8F01 AA53 E080  3F3C F17F B0A1 D44E 4FEE

Attachment: signature.asc
Description: PGP signature

Reply via email to