On 2015/01/08 12:38, Mikolaj Kucharski wrote:
> In post-extract I would use ${INSTALL_SCRIPT} or ${INSTALL_DATA} instead
> of cp(1), depending should openbsd.sh have executable bit set or not.

Not for post-extract, ${INSTALL_xx} sets permissions/ownership which is
not wanted in extract.

Manpages are installed to the wrong place.

Looking at the script ... 
http://git.zx2c4.com/password-store/tree/src/password-store.sh
(only briefly, I can't handle reading 160-column-wide shell scripts for very 
long ;)

  #!/usr/bin/env bash

should be patched to use the explicit path (which will need to use ${LOCALBASE}
and SUBST_CMD, or some other method of substituting, rather than hardcoding 
/usr/local).

  local 
passfile_temp="${passfile}.tmp.${RANDOM}.${RANDOM}.${RANDOM}.${RANDOM}.--"

...blech.

Reply via email to