On 2015/05/17 15:10, Dmitrij D. Czarkoff wrote:
> Frederic Cambus said:
> > And here are the files :
> > 
> > http://www.cambus.net/files/openbsd/ansiweather.tar.gz
> 
> It could make sense to set DISTNAME=ansiwhether-${GH_TAGNAME} so that
> version number would be changed only once upon update.  Also, patching
> away curl with ftp command from README.md makes sense.

Agreed.

Also standard style for COMMENT is to lowercase the first letter
unless it's a proper noun.

With those changes I'd be OK to import it.

Seems handy, though it seems to want to display weather for Birmingham
for most place names in the UK (including ones which correctly display
if used on the OpenWeatherMap site).

$ ansiweather -l 'Ottery Saint Mary,UK'
 Current weather in Birmingham => 14 °C ☁  - Wind => 5.87 m/s WSW - Humidity => 
66 % - Pressure => 1024 hPa - Sunrise => May 17 05:07:53 AM - Sunset => May 17 
09:00:06 PM 

$ ansiweather -l 'Bogustownname,UK'
 Current weather in Birmingham => 14 °C ☁  - Wind => 5.87 m/s WSW - Humidity => 
66 % - Pressure => 1024 hPa - Sunrise => May 17 05:07:53 AM - Sunset => May 17 
09:00:06 PM 

$ ansiweather -l 'Exeter,UK'
 Current weather in Exeter => 12 °C ☁  - Wind => 4.87 m/s W - Humidity => 71 % 
- Pressure => 1022 hPa - Sunrise => May 17 05:21:56 AM - Sunset => May 17 
08:59:04 PM 


Reply via email to