Thanks for taking care of this Brian! As I said off-list, the changes looks great, and it makes sense to default on using ftp on OpenBSD.
@sthen: Indeed, just queried the API manually for verification and both "Bogustownname" and "Ottery Saint Mary" return data for Birmingham. Could it be that Birmingham is some kind of geographical centre and the API defaults to it when it doesn't have data for a UK location? On Sun, May 17, 2015 at 3:55 PM, Brian Callahan <[email protected]> wrote: > > On 05/17/15 09:23, Stuart Henderson wrote: >> On 2015/05/17 15:10, Dmitrij D. Czarkoff wrote: >>> Frederic Cambus said: >>>> And here are the files : >>>> >>>> http://www.cambus.net/files/openbsd/ansiweather.tar.gz >>> It could make sense to set DISTNAME=ansiwhether-${GH_TAGNAME} so that >>> version number would be changed only once upon update. Also, patching >>> away curl with ftp command from README.md makes sense. >> Agreed. >> >> Also standard style for COMMENT is to lowercase the first letter >> unless it's a proper noun. >> >> With those changes I'd be OK to import it. > > So I had already done that and sent the result to Frederic. It's > attached. I'm ok with it if someone wants to import. > > ~Brian > >> Seems handy, though it seems to want to display weather for Birmingham >> for most place names in the UK (including ones which correctly display >> if used on the OpenWeatherMap site). >> >> $ ansiweather -l 'Ottery Saint Mary,UK' >> Current weather in Birmingham => 14 °C ☁ - Wind => 5.87 m/s WSW - Humidity >> => 66 % - Pressure => 1024 hPa - Sunrise => May 17 05:07:53 AM - Sunset => >> May 17 09:00:06 PM >> >> $ ansiweather -l 'Bogustownname,UK' >> Current weather in Birmingham => 14 °C ☁ - Wind => 5.87 m/s WSW - Humidity >> => 66 % - Pressure => 1024 hPa - Sunrise => May 17 05:07:53 AM - Sunset => >> May 17 09:00:06 PM >> >> $ ansiweather -l 'Exeter,UK' >> Current weather in Exeter => 12 °C ☁ - Wind => 4.87 m/s W - Humidity => 71 >> % - Pressure => 1022 hPa - Sunrise => May 17 05:21:56 AM - Sunset => May 17 >> 08:59:04 PM >> >> > -- Frederic Cambus - http://www.statdns.com
