On Wed, 20 Apr 2016 01:34:31 +0200 "Dmitrij D. Czarkoff" <czark...@gmail.com> wrote:
> Edd Barrett said: > > > portcheck hardcoded paths detected in pkg/README, consider using > > > SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE > > > net/syncthing > > > > > > not sure what portcheck hates here but it does. Maybe the /var > > > paths? > > > > Yeah, I think it's /var, for which (AFAIK) there is no variable > > for. > > We have two of them: VARBASE and LOCALSTATEDIR. Former may be used > here. > > Adam Wolk said: > > The port uses GH_* variables with are not preferred when upstream > > provides release tarballs and syncthing does. I have been dumb > > enough to try and switch the port to use a normal MASTER_SITES. I'm > > attaching a new port plus a diff so you can see the pain I went > > through to get it working. It's far more uglier than GH_* vars but > > not subject to tag sliding if upstream decides to move it. > > Well, I actually switched my initial port draft to GH_* variables > because it made port much cleaner (easier to maintain). Upstream does > not seem to practice tag sliding. > I agree that this port is much cleaner with GH_* vars and that upstream seems sensible. Just to be clear - still OK awolk@ even when using GH_* vars. > > Are we converging on something importable? > > OK czarkoff@. >
