On Tue, May 24, 2016 at 07:39:27PM +0100, Edd Barrett wrote:
> Hi Sebastien,
>
> Thanks for your work on this. Here's some low hanging fruit.
>
> On Fri, May 20, 2016 at 05:51:54AM +0200, Sebastien Marie wrote:
> > Note it requires the pending lang/rust port update.
>
> Which version? BUILD_DEPENDS says it needs lang/rust>=1.8. Or do you
> mean it needs your LOCALBASE tweak? If so, the BUILD_DEPEND will need a
> bump.
I annoted with lang/rust>=1.8 because rustc 1.7 serie couldn't build cargo
0.10.0,
due to libstd changes.
So rustc 1.8.0 is able to build cargo (if I recall correctly). But due
to limitation in openbsd implementation of rustc, lang/rust-1.8.0 isn't
able to pass cargo tests.
So for a "full and clean" build, lang/rust>=1.8.0p1 is required (and
expected too).
This ports framework part is a bit obscure to me :) So I will update the
BUILD_DEPEND to lang/rust>=1.8.0p1.
Additionnal question: when lang/rust will be updated to 1.9.0, should I
bump devel/cargo in some way ? Asking because in my test host, I have
some errors of "change in plist":
-@sha gIQpq8jQYj/3OF9Z3aoPy/IAzeliydUlF0jcNOswiVg=
-@depend lang/rust,-main:rust-*:rust-1.8.0p1
+@sha FVU7zKydMwqPIfoGtAczmlIYVOAAB4UqUFy1Pvdli5U=
+@depend lang/rust,-main:rust-*:rust-1.9.0
> > -sysconfdir=${LOCALBASE}/share/examples/cargo
>
> Usually syconfdir is /etc, and you use @example in the PLIST to make an
> example. This also means the user can edit the config file without
> upsetting pkg_delete.
>
as sthen@ said, it is for bash_completion.d/cargo file. I will look for
moving it to /usr/local/share/bash-completion/completions/
> > DISTFILES += cargo-bootstrap-${BOOTSTRAP_VERSION}.tar.gz:1
>
> It would be nice to have a target that can make the bootstrap tarball
> automatically, like, for example, the lang/pypy does. Is that possible?
with the current commited state: no (but I have uncommited changes that
will make it possible).
I will update the port to permit cargo to be build with itself
(using a cargo version 0.10.0 to build a cargo version 0.10.0).
The expected result is to be able to update the bootstrap more simply.
Currently the bootstrap is a previous version of the binary (which needs
another previous version for build itself, which...)
> And some boring nitpicking:
>
> "cartes.io" -> "crates.io"?
thanks.
> "the package doesn't contains it" -> "the package doesn't *contain* it"
thanks.
> "licencied" -> "licensed"
thanks.
--
Sebastien Marie
