On 2016/06/07 12:41, David Coppa wrote:
> On Mon, 06 Jun 2016, Stuart Henderson wrote:
> 
> > On 2016/06/06 12:40, Stuart Henderson wrote:
> > > FAILED: shell_integration/dolphin/libownclouddolphinpluginhelper.so 
> > 
> > oh...it didn't attempt to build this file in the previous build.
> > It picks it up because the (fairly recently added) kf5 was present
> > during configure:
> > 
> > -- Found KF5KIO: /usr/local/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found 
> > version "5.21.0") 
> > -- Found KF5: success (found suitable version "5.21.0", minimum required is 
> > "5.16") found components:  KIO 
> > -- Found KF5CoreAddons: 
> > /usr/local/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version 
> > "5.21.0") 
> > -- Found KF5: success (found suitable version "5.21.0", minimum required is 
> > "5.16.0") found components:  CoreAddons KIO 
> > CMake Warning at /usr/local/share/ECM/kde-modules/KDEInstallDirs.cmake:595 
> > (message):
> >   KDE_INSTALL_BINDIR, KDE_INSTALL_LIBDIR and KDE_INSTALL_INCLUDEDIR should
> >   either all be absolute paths or all be relative paths.
> > Call Stack (most recent call first):
> >   shell_integration/dolphin/CMakeLists.txt:22 (include)
> > 
> > I've disabled this in owncloudclient for now. Not sure why linking
> > is failing. FWIW /usr/obj/ports/owncloudclient-2.1.1-qt5/bin/c++ is a
> > symlink pointing to eg++. Anyway the port is "fixed" now at least.
> 
> Hi!
> 
> To keep CMake from searching for a package named "Foo", you can
> just set the variable CMAKE_DISABLE_FIND_PACKAGE_Foo to TRUE.
> This works for any package.
> 
> Here's a diff for owncloudclient:

Oh that's better.

> +                     -DCMAKE_DISABLE_FIND_PACKAGE_KF5=TRUE

Seems we have a few varieties of this in the tree, the only version
missing is =YES..would it make sense to standardise on one? Is there
any advantage to specifying :Bool?

-DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=Yes
-DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=True
-DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=TRUE
-DCMAKE_DISABLE_FIND_PACKAGE_XXX=True
-DCMAKE_DISABLE_FIND_PACKAGE_XXX=TRUE
-DCMAKE_DISABLE_FIND_PACKAGE_XXX=Yes

Not that it hugely matters, but for neatness..

Reply via email to