On Tue, Jun 7, 2016 at 1:31 PM, Stuart Henderson <s...@spacehopper.org> wrote:

> Oh that's better.
>
>> +                     -DCMAKE_DISABLE_FIND_PACKAGE_KF5=TRUE
>
> Seems we have a few varieties of this in the tree, the only version
> missing is =YES..would it make sense to standardise on one? Is there
> any advantage to specifying :Bool?
>
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=Yes
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=True
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX:Bool=TRUE
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX=True
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX=TRUE
> -DCMAKE_DISABLE_FIND_PACKAGE_XXX=Yes
>
> Not that it hugely matters, but for neatness..

I'd settle on:

-DCMAKE_DISABLE_FIND_PACKAGE_XXX=TRUE

variable type (":Bool") is optional.

ciao
David

Reply via email to