On 2016/09/04 10:43, Stephen Graf wrote:
> I have built a port for turnserver-4.5.0.3,
> https://github.com/coturn/coturn.
>
>
>
> It needs an experienced maintainer to complete and verify.
>
>
>
> I have tested the port and am running the results on openBSD 5.9 stable.
> There is a reported dependency problem but it does not seem to affect the
> operation of the sub app involved. The license seems to be a scaled down
> version of some other license, but requires the license file to be included
> in any distribution. This app has been ported on FreeBSD.
>
Port submissions need to be for -current not -stable of an old release.
Looking at the PLIST /usr/local/etc is wrong, you need to install to an
examples dir, @sample into ${SYSCONFDIR}, and teach the software to look
in ${SYSCONFDIR}. /usr/local/var(/db/turndb) is wrong.
rc script is hardcoding paths which should come from variables
(/etc -> ${SYSCONFDIR}, /usr/local -> ${PREFIX}, /var -> ${LOCALSTATEDIR}.
Missing "# $OpenBSD$" rcsid comment in turnserver.rc.
The uid you chose is already taken.
Wouldn't telephony be better than net?
The configure script is picking up various libraries if installed
(postgresql, hiredis, mysqlclient, gettext) these need to be listed
properly in WANTLIB/LIB_DEPENDS or disabled.
DESCR shouldn't have the WWW line, that comes automatically from HOMEPAGE.
The LICENSE/LICENSE_FILE stuff aren't OpenBSD, look at our other ports
to see how this is done.
The MASTER_SITES0/1 construct aren't useful here, it doesn't even use
the files from extradocs.
Zap the CVS dir in the tar.
