On Sun, Mar 05, 2017 at 10:42:33PM +0000, Stuart Henderson wrote:
> On 2017/03/05 23:21, Remi Locherer wrote:
> > attached a port of vdirsyncer plus it's dependencies.
>
> I've just had a quick read through; in a few of the ports you have hardcoded
> ,python3 in deps, this should be ${MODPY_FLAVOR}. It's a noop for vdirsyncer
> itself though we are generally doing this anyway and it saves trouble if
> we change things in ports later, but for some of the other ports it's
> wrong as-is i.e. py-requests-toolbelt depends on www/py-requests,python3
> even for the py27 one. Similarly should use sphinx-build${MODPY_BIN_SUFFIX}
> rather than hardcoded sphinx-build-3.
>
> One other nit, please use "Yes" instead of "YES" for PERMIT_PACKAGE_CDROM.
>
> Other than that, looks good to me.Thank you for reviewing my ports! Attached updated tarballs.
py-atomicwrites.tar.gz
Description: application/tar-gz
py-click-log.tar.gz
Description: application/tar-gz
py-click-threading.tar.gz
Description: application/tar-gz
py-requests-roolbelt.tar.gz
Description: application/tar-gz
vdirsyncer.tar.gz
Description: application/tar-gz
