On 2017/09/30 00:41, Ian Sutton wrote:
> Hello, I've ported some software.
> 
> http://ce.gl/soyuz-port.tgz
> 
> games/soyuz is a spaceflight simulator used to train Soviet cosmonauts
> to fly fourth generation Soyuz rockets in the mid-to-late 1980s, it was
> designed and written by members of the Soviet space program. It
> specifically simulates the instrumentation and control interface for the
> descent module re-entering the atmosphere, and provides a virtual
> interface that functionally matches hardware found in real-life Soyuz modules.
> 
> Here are some screenshots:
> 
> https://ce.gl/soyuz/
> 
> It passes portcheck:
> 
>       0 $ pwd
>       /usr/ports/games/soyuz
>       0 $ /usr/ports/infrastructure/bin/portcheck
>       games/soyuz
> 
> However I'm not very experienced with writing ports and would appreciate
> feedback.
> 
> 
> PS - I'd be interested in hearing from anyone who manages to land,
> because this is beyond difficult :)
> 
> Ian
> 

Diff on top to tidy it up a bit.

I don't read Russian (totally killing my chances of being an astronaut
;) but is there something on the screen you get by pressing T that would
pass for a version number?  Is there copyright information anywhere
that would let us fill in the markers better?

(btw, it's easier to review if you send a tar with just portname/* rather
than usr/ports/category/portname/* .. or category/portname/* if there are
multiple ports in different categories within one submission).

Interesting idea to use dosbox in the port like this :-)

diff --git Makefile Makefile
index f499718..c40031e 100644
--- Makefile
+++ Makefile
@@ -1,51 +1,35 @@
 # $OpenBSD$
 
-COMMENT =      Training program for the Soyuz-TMA spacecraft.
-DISTNAME =     soyuz-1.0
-CATEGORIES =   games
+COMMENT =      training program for the Soyuz-TMA spacecraft
+
+PKGNAME =      soyuz-1.0
+DISTNAME =     soyuz
+DISTSUBDIR =   ${PKGNAME}
+EXTRACT_SUFX = .zip
 
-DISTFILES =    soyuz.zip
-DISTFILES +=   soyuz.conf
-DISTFILES +=   soyuz.sh
+CATEGORIES =   games
 
 MAINTAINER =   Ian Sutton <i...@openbsd.org>
 
-PERMIT_PACKAGE_CDROM = N/A
+# no license information?
+PERMIT_PACKAGE_CDROM = no license information?
 PERMIT_PACKAGE_FTP =   Yes
 
-MASTER_SITES = https://ce.gl/ports/dist/soyuz/
+HOMEPAGE =     https://archive.org/details/demo211
 
-EXTRACT_SUFX =         .zip
-EXTRACT_ONLY =         soyuz.zip
+MASTER_SITES = https://ce.gl/ports/dist/soyuz/
 
-BUILD_DEPENDS =                archivers/unzip
-RUN_DEPENDS =          emulators/dosbox
+RUN_DEPENDS =  emulators/dosbox
 
-NO_BUILD =             Yes
-NO_TEST =              Yes
-NO_CONFIGURE =                 Yes
+NO_BUILD =     Yes
+NO_TEST =      Yes
+WRKDIST =      ${WRKDIR}
 
 do-install:
-       mkdir ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/COLOR.SF ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/EPROM.DAT ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/EPROMSPS.DAT ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/INPU.EXE ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/KS020.DAT ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/MODEL.DAT ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/MONO.SF ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin \
-                ${WRKDIR}/RUNTIME.WP ${PREFIX}/libexec/soyuz/
-       install -D -c -m 755 -o root -g bin ${DISTDIR}/soyuz.sh 
${PREFIX}/bin/soyuz
-       install -D -c -m 755 -o root -g bin ${DISTDIR}/soyuz.conf \
-               ${PREFIX}/libexec/soyuz/soyuz.conf
-
+       ${INSTALL_DATA_DIR} ${PREFIX}/libexec/soyuz/
+       cd ${WRKDIR}; ${INSTALL_DATA} COLOR.SF EPROM.DAT EPROMSPS.DAT \
+           INPU.EXE KS020.DAT MODEL.DAT MONO.SF RUNTIME.WP \
+           ${FILESDIR}/soyuz.conf ${PREFIX}/libexec/soyuz/
+       ${INSTALL_SCRIPT} ${FILESDIR}/soyuz.sh ${PREFIX}/bin/soyuz
 
 .include <bsd.port.mk>

Reply via email to