On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> Klemens Nanni <k...@posteo.org> wrote:
> > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > beneath COMMENT; see infrastructure/templates/Makefile.template.
> >
> > RUN_DEPENDS lacks net/tor.
> > onionshare-gui still starts but python will dump core when
> > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > "Tor that is bundled with OpenShare" which is misleading.
> >
> > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
>
> Attached is an updated port that addresses all of these comments.
> Thanks a lot for the feedback!
Looks good to me except for the bundle bits. Optimally this should be
clarified upstream.
