On Sat, 23 Dec 2017 13:20:05 +0100, Landry Breuil <lan...@openbsd.org> wrote:
> On Mon, Dec 18, 2017 at 08:23:34PM +0100, Landry Breuil wrote: > > On Thu, Dec 14, 2017 at 09:17:11PM +0100, Klemens Nanni wrote: > > > On Wed, Dec 13, 2017 at 04:39:57PM +0100, Landry Breuil wrote: > > > > Starting from this i dunno if it warrants a readme or a > > > > MESSAGE, you just need to go fetch the access/secret keys in > > > > the config file after first startup, and maybe bump maxfiles > > > > limits for minio (as advised on > > > > https://github.com/minio/minio-service - the sysv init script > > > > bumps to 8k) > > > Users should know how to use minio, I'd say it's fine without > > > further explanation. > > > > > > $ portcheck > > > Makefile.inc does not have $OpenBSD$ RCS tag at the top > > > hardcoded paths detected in server/pkg/minio.rc, consider > > > \ using SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE > > > net/minio > > > > > > s,/var,${VARBASE}, > > > > With those fixed. > > Now with mc updated to 20171212 > (cf > https://github.com/minio/mc/releases/tag/RELEASE.2017-12-12T01-08-02Z) > and the single patch in an upstream PR at > https://github.com/minio/mc/pull/2342 Can you register the uid 796 in user.list asap to be sure there won't be another race please? As stated in a previous email for yours: > Myeah. Here's a version with an rc script, running by default as > _minio and exporting /var/minio/export, storing the config in > /var/minio/.minio/config.json. > > Starting from this i dunno if it warrants a readme or a MESSAGE, you > just need to go fetch the access/secret keys in the config file after > first startup, and maybe bump maxfiles limits for minio (as advised on > https://github.com/minio/minio-service - the sysv init script bumps to > 8k) I think a readme would be really worth it. Here's the diff from my review (with Klemens's remark). diff -pruN /tmp/hometmp/minio/Makefile minio/Makefile --- /tmp/hometmp/minio/Makefile Sat Dec 9 17:04:03 2017 +++ minio/Makefile Sat Dec 23 14:17:16 2017 @@ -1,6 +1,7 @@ # $OpenBSD$ -SUBDIR = client +SUBDIR = +SUBDIR += client SUBDIR += server .include <bsd.port.subdir.mk> diff -pruN /tmp/hometmp/minio/Makefile.inc minio/Makefile.inc --- /tmp/hometmp/minio/Makefile.inc Thu Dec 14 16:06:31 2017 +++ minio/Makefile.inc Sat Dec 23 14:26:39 2017 @@ -1,7 +1,6 @@ # $OpenBSD$ GH_ACCOUNT ?= minio -GH_PROJECT ?= minio CATEGORIES = net sysutils @@ -9,5 +8,7 @@ HOMEPAGE = https://minio.io # APACHEv2 PERMIT_PACKAGE_CDROM = Yes + +WANTLIB += c pthread MODULES = lang/go diff -pruN /tmp/hometmp/minio/client/pkg/DESCR minio/client/pkg/DESCR --- /tmp/hometmp/minio/client/pkg/DESCR Sat Dec 9 16:54:49 2017 +++ minio/client/pkg/DESCR Sat Dec 23 14:18:42 2017 @@ -1,3 +1,3 @@ -Minio Client (mc) provides a modern alternative to UNIX commands like +Minio Client (minioc) provides a modern alternative to UNIX commands like ls, cat, cp, mirror, diff, find etc. It supports filesystems and Amazon S3 compatible cloud storage service (AWS Signature v2 and v4). diff -pruN /tmp/hometmp/minio/server/pkg/PLIST minio/server/pkg/PLIST --- /tmp/hometmp/minio/server/pkg/PLIST Wed Dec 13 10:27:33 2017 +++ minio/server/pkg/PLIST Sat Dec 23 14:20:17 2017 @@ -1,6 +1,6 @@ @comment $OpenBSD$ -@newgroup _minio:795 -@newuser _minio:795:_minio:daemon:Minio user:${VARBASE}/minio:/sbin/nologin +@newgroup _minio:796 +@newuser _minio:796:_minio:daemon:Minio user:${VARBASE}/minio:/sbin/nologin @bin bin/minio @rcscript ${RCDIR}/minio @owner _minio Once you show me the readme, I'll give you the long awaited ok ;)
