On 2017/12/24 21:42, Adam Wolk wrote: > On Sun, Dec 24, 2017 at 01:09:45AM +0000, Thomas Frohwein wrote: > > Follow up: The music of witchblast is licensed under CC BY-NC-SA. I grepped > > through ports and found games/dangerdeep and books/progit that also are CC > > BY-NC-SA. > > > > Based on that I set: > > > > PERMIT_PACKAGE_CDROM = Non-commercial > > PERMIT_PACKAGE_FTP = Yes > > > > Otherwise bump - it's a neat game with good music, worth a try. > > The game is indeed amazing, great find thanks! > > 1. I think it's worth to mention SIL Open Font License in the license comment. > That license file is installed along the fonts used by the game.
yep. > 2. I found the F1 screenshot of the death certificate utility broken. > Failed to save image "rip_20171224212927.png" > > That is because it saves to the current directory in src/WitchBlastGame.cpp: > void WitchBlastGame::saveDeathScreen() > > might be worth patching that so it saves to somewhere in users $HOME? the most obvious place would be ~/.local/share/witchblast/data, but I don't think it's needed for import. > 3. There are some issues with getting this game to use the full screen in i3. > It's 100% playable but does weird things on death (double display for a > moment), > and doesn't take the whole real estate. I don't think however that this is a > blocker. +1. > With the above changed it's OK awolk@ assuming we can get a second OK from > someone > to import this :) Obfuscated email addresses don't work for MAINTAINER. Other than that I'm OK with just the license fix to import. Thomas, please use a subdirectory in tar files, it's easier to handle that way.
