On Sun, Dec 24, 2017 at 09:08:57PM +0000, Stuart Henderson wrote:
> On 2017/12/24 21:42, Adam Wolk wrote:
> > On Sun, Dec 24, 2017 at 01:09:45AM +0000, Thomas Frohwein wrote:
> > > Follow up: The music of witchblast is licensed under CC BY-NC-SA. I 
> > > grepped through ports and found games/dangerdeep and books/progit that 
> > > also are CC BY-NC-SA.
> > > 
> > > Based on that I set:
> > > 
> > > PERMIT_PACKAGE_CDROM = Non-commercial
> > > PERMIT_PACKAGE_FTP = Yes
> > > 
> > > Otherwise bump - it's a neat game with good music, worth a try.
> > 
> > The game is indeed amazing, great find thanks!
> > 
> > 1. I think it's worth to mention SIL Open Font License in the license 
> > comment.
> > That license file is installed along the fonts used by the game.
> 
> yep.
> 
> > 2. I found the F1 screenshot of the death certificate utility broken.
> >  Failed to save image "rip_20171224212927.png"
> > 
> > That is because it saves to the current directory in src/WitchBlastGame.cpp:
> >  void WitchBlastGame::saveDeathScreen()
> > 
> > might be worth patching that so it saves to somewhere in users $HOME?
> 
> the most obvious place would be ~/.local/share/witchblast/data, but I don't 
> think
> it's needed for import.
> 

I'm attaching a patch doing just that. I did find it cropping the output on i3
due to the game having issue with determining it's dimensions on a tilling WM.
When launched as a floating window it saves nicely looking death certificates.

First 3 images on the link below show a tilling WM bug, the other one shows it
working with floating window. People running xfce and other non tilling WM's
won't have the problem so I thikn the patch is worth it.

> > 3. There are some issues with getting this game to use the full screen in 
> > i3.
> > It's 100% playable but does weird things on death (double display for a 
> > moment),
> > and doesn't take the whole real estate. I don't think however that this is 
> > a blocker.
> 
> +1.
> 
> > With the above changed it's OK awolk@ assuming we can get a second OK from 
> > someone
> > to import this :)
> 
> Obfuscated email addresses don't work for MAINTAINER. Other than that I'm OK
> with just the license fix to import.
> 
> Thomas, please use a subdirectory in tar files, it's easier to handle that 
> way.
> 

I'll import when Thomas submits an update with the license change & MAINTAINER 
fix.
I'm leaving it up to you Thomas whether to include or not the screenshot patch.

Regards,
Adam
$OpenBSD$

Index: src/WitchBlastGame.cpp
--- src/WitchBlastGame.cpp.orig
+++ src/WitchBlastGame.cpp
@@ -2816,7 +2816,7 @@ void WitchBlastGame::renderMessages()
 void WitchBlastGame::saveDeathScreen()
 {
   std::stringstream ss;
-  ss << "rip_";
+  ss << BASE_DATA_DIR << "data/rip_";
   time_t t = time(0);   // get time now
   struct tm * now = localtime( & t );
 

Reply via email to