Thanks Stuart and Marc - I adjusted the port based on your comments.
pl0 -> pl1, CONFIGURE_ARGS+= -DUSE_QT4=OFF, @cwd is gone

New version attached.

On Mon, Mar 05, 2018 at 08:53:05AM +0000, Stuart Henderson wrote:
> On 2018/03/04 11:05, Thomas Frohwein wrote:
> > On Sun, Mar 04, 2018 at 05:31:31PM +1100, Jonathan Gray wrote:
> > > 1.1.2-r1 may map to 1.1.2pl1 (1.1.2 patch level 1) if I read
> > > packages-specs(7) correctly as there was a 1.1.2 release prior to r1.
> > 
> > I looked through packages. There are a few packages with pl0 (apvlv,
> > inotify-tools, and xarchiver) and since we also start with v0 and p0, I set 
> > this
> > to arx-libertatis-1.1.2pl0.
> 
> the number after pl usually maps directly to something from upstream,
> I'd go for:
> 
> GH_ACCOUNT =    arx
> GH_PROJECT =    ArxLibertatis
> GH_TAGNAME =    1.1.2-r1
> PKGNAME =     arx-libertatis-${GH_TAGNAME:S/-r/pl/}
> 
> > I updated PLIST again because update-desktop-database should really be in
> > there AFAIU. Not sure if the @cwd /usr/local is needed, but it seemed safer 
> > to
> > put it in there. Built it again and ran it without any issues.
> 
> @cwd does nothing here. It's used for rare cases where you have some
> files under one PREFIX and other files under another directory in the same
> package (most common for files installed to /var/www where there's also
> a pkg-readme file).
> 
> : -option(USE_QT4 "Use Qt 4 if available" ON)
> : +option(USE_QT4 "Use Qt 4 if available" OFF)
> 
> CONFIGURE_ARGS= -DUSE_QT4=OFF
> 

Attachment: arx-libertatis.tgz
Description: Binary data

Reply via email to