On 04/17/2018 02:52 PM, Stuart Henderson wrote:

+-static BOOL srandomed = FALSE;
+
+ /* speedup, if we have only 1 server */
+ if (num_servers == 1)
+   return (spamds[0]->is_failed ? -1 : 0);
+
+-/* init ranmod */
+-if (!srandomed)

Honestly I would leave the srandom bits in. No major objection, but they
don't hurt and it will save you maintenance hassle merging patches when
they fix the typo in the comment you are removing in this patch!
Minimal patches are usually better.

That's not really a big hassle as I will probably make more changes (pledge anyone?). Besides, I would prefer not to create a variable if it can be trivially avoided.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to