On Sun, Apr 29, 2018 at 12:43:15PM +0200, Landry Breuil wrote: > On Sun, Apr 29, 2018 at 01:33:57PM +0300, mazocomp wrote: > > On Sun, Apr 29, 2018 at 01:27:14PM +0300, mazocomp wrote: > > > On Sun, Apr 29, 2018 at 12:13:16PM +0200, Landry Breuil wrote: > > > > On Sun, Apr 29, 2018 at 12:41:01PM +0300, mazocomp wrote: > > > > > On Sat, Apr 28, 2018 at 08:17:56PM -0400, Brian Callahan wrote: > > > > > > > > > > > > On 04/28/18 19:43, mazocomp wrote: > > > > > > > Hi! > > > > > > > > > > > > > > Is there any hope this port will be accepted > > > > > > > or should I keep maintaining it in WIP tree? > > > > > > > > > > > > > > I know toxcore is unstable, but I don't know alternatives. > > > > > > > (except bloated ricochet and retroshare) > > > > > > > > > > > > > > > > > > > toxcore's license marker should be tweaked to GPLv3+, otherwise ok. > > > > > > toxic doesn't need HOMEPAGE set if you're using GH_*, otherwise ok. > > > > > > utox sets -std=gnu11 so should have COMPILER=base-clang ports-gcc, > > > > > > also > > > > > > needs NO_TEST=Yes, otherwise ok. > > > > > > > > > > > Ok, done. > > > > > > > > > > > I don't know anyone who uses tox so I can't test beyond making sure > > > > > > they > > > > > > start up and close without crashing, with both do. > > > > > > > > > > > > You are not listed as MAINTAINER of any of these. Do you want to be > > > > > > MAINTAINER? > > > > > > > > > > > Oh, can I? Ok, I'll try. > > > > > > > > I think you need to set USE_LIBTOOL = Yes (or gnu, depending on how it > > > > uses it) in toxcore so that proper setup of libtool is done. Besides > > > > that those ports look okay to me. > > > > > > > > Landry > > > > > > > After testing both of that I can't find file shared_libs.log > > > (I used find(1)), should I still set USE_LIBTOOL to Yes or gnu? > > > > > I'm not sure this is right, but ok: > > The rationale is to not explicitely adding libtool from ports (the gnu > one) unless its really needed, ie delete ports libtool, figure out if > the port is fine with the base libtool, and then set USE_LIBTOOL=yes > which will set LIBTOOL in the env during build. If you set it to 'gnu' > it will also add devel/libtool to the build depends. Oh, I am so blind. Toxcore doesn't use both devel/libtool and devel/check anymore.
tox,4.tar.gz
Description: application/tar-gz
